From 288c843a1760ef576cab02c944d633e793582149 Mon Sep 17 00:00:00 2001 From: Cesar Celis Hernandez Date: Mon, 29 Aug 2022 20:28:39 -0400 Subject: [PATCH] Catch error in gofmt (#2266) --- Makefile | 5 +---- verify-gofmt.sh | 12 ++++++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) create mode 100755 verify-gofmt.sh diff --git a/Makefile b/Makefile index 2057bc0d4..6ac173b9b 100644 --- a/Makefile +++ b/Makefile @@ -28,10 +28,7 @@ verifiers: getdeps fmt lint fmt: @echo "Running $@ check" - @GO111MODULE=on gofmt -d restapi/ - @GO111MODULE=on gofmt -d pkg/ - @GO111MODULE=on gofmt -d cmd/ - @GO111MODULE=on gofmt -d cluster/ + @(env bash $(PWD)/verify-gofmt.sh) crosscompile: @(env bash $(PWD)/cross-compile.sh $(arg1)) diff --git a/verify-gofmt.sh b/verify-gofmt.sh new file mode 100755 index 000000000..ee14df4ab --- /dev/null +++ b/verify-gofmt.sh @@ -0,0 +1,12 @@ +#!/bin/bash + +# Expanding gofmt to cover more areas. +# This will include auto generated files created by Swagger. +# Catching the difference due to https://github.com/golang/go/issues/46289 +DIFF=$(GO111MODULE=on gofmt -d .) +if [[ -n $DIFF ]]; +then + echo "$DIFF"; + echo "please run gofmt"; + exit 1; +fi