From 56f22a447947ca06ca68828c1924963012117926 Mon Sep 17 00:00:00 2001
From: jinapurapu <65002498+jinapurapu@users.noreply.github.com>
Date: Thu, 13 Jun 2024 11:06:30 -0700
Subject: [PATCH] Fix storageClass on EditLifecycleModal (#3379)

---
 .../EditLifecycleConfiguration.tsx            | 31 ++++++++++++-------
 1 file changed, 20 insertions(+), 11 deletions(-)

diff --git a/web-app/src/screens/Console/Buckets/BucketDetails/EditLifecycleConfiguration.tsx b/web-app/src/screens/Console/Buckets/BucketDetails/EditLifecycleConfiguration.tsx
index 7ba0f15f4..62cfbf662 100644
--- a/web-app/src/screens/Console/Buckets/BucketDetails/EditLifecycleConfiguration.tsx
+++ b/web-app/src/screens/Console/Buckets/BucketDetails/EditLifecycleConfiguration.tsx
@@ -92,10 +92,9 @@ const EditLifecycleConfiguration = ({
 
               return { label: value, value: value };
             });
-
             setTiersList(objList);
             if (objList.length > 0) {
-              setStorageClass(objList[0].value);
+              setStorageClass(lifecycleRule.transition?.storage_class || "");
             }
           }
           setLoadingTiers(false);
@@ -104,18 +103,28 @@ const EditLifecycleConfiguration = ({
           setLoadingTiers(false);
         });
     }
-  }, [loadingTiers]);
+  }, [loadingTiers, lifecycleRule.transition?.storage_class]);
 
   useEffect(() => {
     let valid = true;
 
     if (ilmType !== "expiry") {
-      if (storageClass === "") {
+      if (
+        (transitionDays !== "0" && storageClass === "") ||
+        (NCTransitionDays !== "0" && NCTransitionSC === "")
+      ) {
         valid = false;
       }
     }
     setIsFormValid(valid);
-  }, [ilmType, expiryDays, transitionDays, storageClass]);
+  }, [
+    ilmType,
+    expiryDays,
+    transitionDays,
+    storageClass,
+    NCTransitionDays,
+    NCTransitionSC,
+  ]);
 
   useEffect(() => {
     if (lifecycleRule.status === "Enabled") {
@@ -439,15 +448,15 @@ const EditLifecycleConfiguration = ({
                     value={NCTransitionDays}
                     min="0"
                   />
-                  <InputBox
+                  <Select
+                    label="Non-current Version Transition Storage Class"
                     id="noncurrentversion_t_SC"
                     name="noncurrentversion_t_SC"
-                    onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
-                      setNCTransitionSC(e.target.value);
-                    }}
-                    placeholder="Set Non-current Version Transition Storage Class"
-                    label="Non-current Version Transition Storage Class"
                     value={NCTransitionSC}
+                    onChange={(value) => {
+                      setNCTransitionSC(value);
+                    }}
+                    options={tiersList}
                   />
                 </Fragment>
               )}